| From: | Marko Kreen <markokr(at)gmail(dot)com> |
|---|---|
| To: | "Dr(dot) Andreas Kunert" <kunert(at)cms(dot)hu-berlin(dot)de> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Feature request: Logging SSL connections |
| Date: | 2013-12-08 09:27:37 |
| Message-ID: | 20131208092737.GB10349@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 06, 2013 at 02:53:27PM +0100, Dr. Andreas Kunert wrote:
> >>Anything else missing?
> >
> >Functionally it's fine now, but I see few style problems:
> >
> >- "if (port->ssl > 0)" is wrong, ->ssl is pointer. So use just
> > "if (port->ssl)".
> >- Deeper indentation would look nicer with braces.
> >- There are some duplicated message, could you restructure it so that
> > each message exists only once.
>
> New version is attached. I could add braces before and after the
> ereport()-calls too, but then I need two more #ifdefs to catch the
> closing braces.
Thank you. Looks good now. I added it to next commitfest:
https://commitfest.postgresql.org/action/patch_view?id=1324
--
marko
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kohei KaiGai | 2013-12-08 10:52:12 | Re: shared memory message queues |
| Previous Message | Pavel Stehule | 2013-12-08 08:45:01 | Re: plpgsql_check_function - rebase for 9.3 |