Re: MultiXact truncation, startup et al.

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: MultiXact truncation, startup et al.
Date: 2013-11-30 16:34:47
Message-ID: 20131130163447.GE31100@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2013-11-30 17:06:31 +0100, Andres Freund wrote:
> On 2013-11-30 10:57:43 -0500, Tom Lane wrote:
> > Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > > Okay, I have pushed all these patches, including the fixes suggested
> > > here and then some.
> >
> > Not sure exactly which patch caused it, but I'm getting a warning
> > in 9.0 through 9.2:
> >
> > multixact.c:1553: warning: no previous prototype for 'TrimMultiXact'
>
> Hm. There's been a mistake during the back-patching of that
> patch. Likely due to the difference in how multixacts work between 9.2
> and 9.3.
> Let me provide a fixup patch.

Attached.

I've tested that pg_multixact gets cleaned up on both primary and a HS
standby, and that things continue work after failover.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-Fix-incomplete-backpatch-of-the-pg_multixact-truncat.patch text/x-patch 2.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2013-11-30 16:40:36 Re: Incomplete freezing when truncating a relation during vacuum
Previous Message Andres Freund 2013-11-30 16:22:04 Re: Incomplete freezing when truncating a relation during vacuum