Re: [COMMITTERS] pgsql: Rework SSL renegotiation code

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Jaime Casanova <jaime(at)2ndquadrant(dot)com>, Vik Fearing <vik(dot)fearing(at)dalibo(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Rework SSL renegotiation code
Date: 2013-10-17 15:42:46
Message-ID: 20131017154245.GF9746@eldon.alvh.no-ip.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Vik Fearing wrote:
> On 09/23/2013 10:51 PM, Alvaro Herrera wrote:
> > + /* are we in the middle of a renegotiation? */
> > + static bool in_ssl_renegotiation = false;
>
> Since this was committed, I'm getting the following warning:
>
> be-secure.c:105:13: warning: ‘in_ssl_renegotiation’ defined but not used
> [-Wunused-variable]

Jaime Casanova wrote:

> Shouldn't this new variable be declared inside the #ifdef USE_SSL block?
> My compiler is giving me a warning for the unused variable

Yep, thanks guys. Just pushed a fix.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2013-10-17 16:29:33 pgsql: Remove spinlock support for SINIX, Sun3, and NS32K.
Previous Message Andrew Dunstan 2013-10-17 15:13:20 pgsql: Return valid json when converting an empty hstore.

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2013-10-17 15:55:14 Re: Auto-tuning work_mem and maintenance_work_mem
Previous Message Andrew Dunstan 2013-10-17 14:43:32 Re: [PATCH] hstore_to_json: empty hstores must return empty json objects