Re: FW: REVIEW: Allow formatting in log_line_prefix

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: FW: REVIEW: Allow formatting in log_line_prefix
Date: 2013-09-24 16:51:04
Message-ID: 20130924165104.GQ4832@eldon.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley escribió:

> I do see a 15-18% slow down with the patched version, so perhaps I'll need
> to look to see if I can speed it up a bit, although I do feel this
> benchmark is not quite a normal workload.

Ouch. That's certainly way too much. Is the compiler inlining
process_log_prefix_padding()? If not, does it do it if you add "inline"
to it? That might speed up things a bit. If that's not enough, maybe
you need some way to return to the original coding for the case where no
padding is set in front of each option.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2013-09-24 17:04:49 Re: record identical operator
Previous Message Jeff Janes 2013-09-24 16:51:00 Re: [PATCH] bitmap indexes