Re: BUG #8410: out of binary heap slots

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: terje(at)elde(dot)net, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #8410: out of binary heap slots
Date: 2013-08-30 21:30:12
Message-ID: 20130830213012.GD8932@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 2013-08-30 17:23:51 -0400, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > No need, found the bug. And I think can build a testcase myself.
>
> > ExecReScanMergeAppend resets ms_initialized, but doesn't clear the
> > binaryheap. Thus no new elements fit.
>
> Sounds like a bug all right, but I'm not convinced it explains Terje's
> report. The thing this theory doesn't explain is why would Terje be
> having trouble reproducing the failure? Seems like re-running the same
> query ought to produce the same failure.

The number of rescans can be rather data-dependant, so I'd guess that's
the reason. If many of the subplans don't return a tuple, it can take
several resets to actually ever reach the heap's limit as we don't
add the subplan to the heap in that case.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Terje Elde 2013-08-30 21:31:36 Re: BUG #8410: out of binary heap slots
Previous Message Andres Freund 2013-08-30 21:27:07 Re: BUG #8410: out of binary heap slots