Re: Kudos for Reviewers -- wrapping it up

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Kudos for Reviewers -- wrapping it up
Date: 2013-08-02 20:56:47
Message-ID: 20130802205647.GE14543@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 2, 2013 at 04:43:30PM -0400, Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > On Fri, Jul 12, 2013 at 12:18:15PM -0700, Joshua D. Drake wrote:
>
> > > Right cause if a reviewer ends up writing (or cleaning up) all the
> > > docs, I would say they deserve very close to equal credit. As an
> > > example.
> >
> > I can do whatever we agree to in the release notes. The big question
> > is whether committers can properly document these people.
>
> I don't see why not. Most of them, if not all, already do.

Do they record which reviewers changed code and which just gave
feedback?

> > I do think the names are going to overwhelm the release note items and
> > we will _again_ remove some or all names.
>
> There's plenty of opinion to the contrary; but then it's just opinion.
> I think the idea of trying it at least once has merit.

This is what the 9.2 release notes looked like before I remove the
reviewers:

http://momjian.us/expire/release-9-2.html

Most items had 2-3 names, and it was widely rejected. Of course, these
were all reviewers, not just those that changed the code. I did not
have details of which reviewers changed code and which just gave
feedback.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2013-08-02 21:07:53 Re: Kudos for Reviewers -- wrapping it up
Previous Message Stephen Frost 2013-08-02 20:48:24 Re: Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])