| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila(at)huawei(dot)com> |
| Cc: | 'Michael Paquier' <michael(dot)paquier(at)gmail(dot)com>, 'Robert Haas' <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Regarding BGworkers |
| Date: | 2013-08-02 04:40:16 |
| Message-ID: | 20130802044016.GH5669@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Amit Kapila escribió:
>
> On Friday, August 02, 2013 4:19 AM Michael Paquier wrote:
> >On Fri, Aug 2, 2013 at 1:22 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> >> On Sun, Jul 28, 2013 at 1:26 AM, Amit kapila <amit(dot)kapila(at)huawei(dot)com> wrote:
> >>> 2. Shouldn't function
> >>> do_start_bgworker()/StartOneBackgroundWorker(void) be moved to
> >>> bgworker.c
> >>> as similar functions AutoVacWorkerMain()/PgArchiverMain() are in
> >>> their respective files.
>
> >> Yes, perhaps so. Other votes?
>
> > StartOneBackgroundWorker uses StartWorkerNeeded and HaveCrashedWorker, and
> > IMO, we should not expose that outside the postmaster.
>
> How about exposing Set/Get for these from bgworker?
That seems more mess than just keeping that function in postmaster.c.
I agree with moving the other one.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2013-08-02 05:00:45 | Re: Should we automatically run duplicate_oids? |
| Previous Message | Amit Kapila | 2013-08-02 04:35:36 | Re: Regarding BGworkers |