| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Maciej Gajewski <maciej(dot)gajewski0(at)gmail(dot)com> |
| Cc: | ian link <ian(at)ilink(dot)io>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Review: query result history in psql |
| Date: | 2013-06-27 17:53:20 |
| Message-ID: | 20130627175319.GH3757@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Maciej Gajewski escribió:
> > Those issues aside - I think it's a great feature! I can add the
> > grammatical fixes I made whenever the final patch is ready. Or earlier,
> > whatever works for you. Also, this is my first time reviewing a patch, so
> > please let me know if I can improve on anything. Thanks!
>
> This is my first submitted patch, so I can't really comment on the
> process. But if you could add the author's email to CC, the message would
> be much easier to spot. I replied after two days only because I missed the
> message in the flood of other pgsql-hacker messages. I think I need to scan
> the list more carefully...
It's better to post a review as a reply to the message which contains
the patch.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-06-27 18:11:59 | Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review] |
| Previous Message | Andres Freund | 2013-06-27 17:36:22 | Re: XLogInsert scaling, revisited |