Re: [9.4 CF 1] The Commitfest Slacker List

On 2013-06-24 14:48:32 -0300, Claudio Freire wrote:
> On Mon, Jun 24, 2013 at 2:41 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> >> I don't like idea of sending gifts. I do like the idea of public thanks. We
> >> should put full recognition in the release notes for someone who reviews a
> >> patch. If they didn't review the patch, the person that wrote the patch
> >> would not have gotten the patch committed anyway. Writing the patch is only
> >> have the battle.
> >>
> >> Heck, think about the FKLocks patch, Alvaro wrote that patch but I know that
> >> Noah (as well as others) put a herculean effort into helping get it
> >> committed.
> >>
> >> Reviewer recognition should be on the same level as the submitter.
> >
> > The problem with that is that that HUGELY depends on the patch and the
> > review. There are patches where reviewers do a good percentage of the
> > work and others where they mostly tell that "compiles & runs".
>
>
> Well, you can't so arbitrarily pick who you're recognizing as
> contributor and who you aren't. So why not mention them all? They did
> work for it, some more than others, but they all worked. And since
> whoever submitted a patch (and got it committed) must have reviewed
> something as well, they'd be recognized for both reviewing and
> submitting.

Because spending a year working on a feature isn't the same as spending
an hour or day on it. And the proposal was to generally list them at the
same level.
At least the 9.3 release notes seem to list people that reviewed
extensively prominently on the patches...

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services