| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Remove useless USE_PGXS support in contrib |
| Date: | 2013-06-15 18:28:25 |
| Message-ID: | 20130615182825.GE3753@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Craig Ringer wrote:
> On 06/13/2013 11:16 AM, Peter Eisentraut wrote:
> > This has served no purpose except to
> >
> > 1. take up space
> > 2. confuse users
> > 3. produce broken external extension modules that take contrib as an example
> > 4. break builds of PostgreSQL when users try to fix 3. by exporting USE_PGXS
>
> Weak -1 from me; I find being able to build contrib modules using PGXS
> from the source tree extremely useful in development. It allows me to
> easily install an extension from a newer Pg version into an older
> server, test against older servers, etc.
This use case seems too narrow to me to justify the burden of keeping
PGXS-enabled makefiles in contrib.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2013-06-15 18:36:54 | Re: Patch for fail-back without fresh backup |
| Previous Message | Tom Lane | 2013-06-15 16:52:32 | Postgres 9.3beta2 coming week after next |