From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
Cc: | PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch to make pgindent work cleanly |
Date: | 2013-04-12 15:44:58 |
Message-ID: | 20130412154458.GA28226@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Feb 19, 2013 at 04:50:45PM -0500, Gurjeet Singh wrote:
> Please find attached the patch for some cleanup and fix bit rot in pgindent
> script.
>
> There were a few problems with the script.
>
> .) It failed to use the $ENV{PGENTAB} even if it was set.
> .) The file it tries to download from Postgres' ftp site is no longer present.
> ftp://ftp.postgresql.org/pub/dev/indent.netbsd.patched.tgz
> .) The tar command extracted the above-mentioned file to a child directory, but
> did not descend into it before running make on it.
> I think it expected a tarbomb, but clearly the current .tgz file on ftp
> site is not a tarbomb.
>
> I don't like the fact that it dies with a message "fetching xyz" rather than
> saying "Could not fetch xyz", but this patch does not address that since it
> doesn't really affect the output when script does work.
>
> With this patch in place I could very easily run it on any arbitrary file,
> which seemed like a black-magic before the patch.
>
> src/tools/pgindent/pgindent --build <your file path here>
I have applied this patch. However, I modified the tarball name to
reference $INDENT_VERSION, rather than hard-coding "1.2".
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2013-04-12 15:51:19 | Re: Detach/attach table and index data files from one cluster to another |
Previous Message | Dickson S. Guedes | 2013-04-12 15:38:22 | Re: Analyzing bug 8049 |