Re: [PATCH] pg_regress and non-default unix socket path

Robert Haas escribió:
> On Tue, Apr 9, 2013 at 8:08 AM, Christoph Berg <cb(at)df7cb(dot)de> wrote:
> > Debian has been patching pg_regress for years because our default unix
> > socket directory is /var/run/postgresql, but that is not writable by
> > the build user at build time. This used to be a pretty ugly "make-
> > patch-make check-unpatch-make install" patch dance, but now it is a
> > pretty patch that makes pg_regress accept --host=/tmp.
> >
> > The patch is already part of the .deb files on apt.postgresql.org and
> > passes all regression test suites there.
> >
> > Please consider it for 9.3. (And maybe backpatch it all the way...)
>
> The hunk that changes the messages might need some thought so that it
> doesn't cause a translation regression.

FWIW I don't think we translate pg_regress at all, and I have my doubts
that it makes much sense. I'd go as far as suggest we get rid of the _()
decorations in the lines we're changing.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services