Re: [PATCH] pg_regress and non-default unix socket path

From: Christoph Berg <cb(at)df7cb(dot)de>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] pg_regress and non-default unix socket path
Date: 2013-04-12 12:45:48
Message-ID: 20130412124548.GA7328@msgid.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Re: To PostgreSQL Hackers 2013-04-09 <20130409120807(dot)GD26705(at)msgid(dot)df7cb(dot)de>

If the patch looks too intrusive at this stage of the release, it
would be enough if the last chunk got included, which should really be
painless:

> diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c
> new file mode 100644
> index b632326..d4d4279
> *** a/src/test/regress/pg_regress.c
> --- b/src/test/regress/pg_regress.c

[...]

> *************** regression_main(int argc, char *argv[],
> *** 2249,2255 ****
> */
> header(_("starting postmaster"));
> snprintf(buf, sizeof(buf),
> ! SYSTEMQUOTE "\"%s/postgres\" -D \"%s/data\" -F%s -c \"listen_addresses=%s\" > \"%s/log/postmaster.log\" 2>&1" SYSTEMQUOTE,
> bindir, temp_install,
> debug ? " -d 5" : "",
> hostname ? hostname : "",
> --- 2254,2262 ----
> */
> header(_("starting postmaster"));
> snprintf(buf, sizeof(buf),
> ! hostname && *hostname == '/'
> ! ? SYSTEMQUOTE "\"%s/postgres\" -D \"%s/data\" -F%s -k \"%s\" > \"%s/log/postmaster.log\" 2>&1" SYSTEMQUOTE
> ! : SYSTEMQUOTE "\"%s/postgres\" -D \"%s/data\" -F%s -c \"listen_addresses=%s\" > \"%s/log/postmaster.log\" 2>&1" SYSTEMQUOTE,
> bindir, temp_install,
> debug ? " -d 5" : "",
> hostname ? hostname : "",

Christoph
--
cb(at)df7cb(dot)de | http://www.df7cb.de/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-04-12 13:00:51 Re: [sepgsql 2/3] Add db_schema:search permission checks
Previous Message Hannu Krosing 2013-04-12 12:07:33 Re: [GSOC] questions about idea "rewrite pg_dump as library"