From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: machine-parseable object descriptions |
Date: | 2013-03-20 21:22:38 |
Message-ID: | 20130320212238.GH3688@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > One change I made was to move all the new code from dependency.c into
> > objectaddress.c. The only reason it was in dependency.c was that
> > getObjectDescription was there in the first place; but it doesn't seem
> > to me that it really belongs there. (Back when it was first created,
> > there was no objectaddress.c at all, and dependency.c was the only user
> > of it.) If there were no backpatching considerations, I would suggest
> > we move getObjectDescription() to objectaddress.c as well, but I'm not
> > sure it's worth the trouble, but I'm not wedded to that if somebody
> > thinks both things should be kept together.
>
> +1 for moving getObjectDescription to objectaddress.c. As you say,
> that's probably where it would've been if that file had existed at
> the time. I don't recall that we've had to back-patch many changes
> in that function, so I don't think that concern is major.
Okay, I have pushed it with that change. Thanks for the quick feedback.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2013-03-20 21:42:15 | Re: sql_drop Event Triggerg |
Previous Message | Peter Eisentraut | 2013-03-20 21:17:11 | Re: find libxml2 using pkg-config |