Re: in-catalog Extension Scripts and Control parameters (templates?)

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: in-catalog Extension Scripts and Control parameters (templates?)
Date: 2013-03-04 11:20:46
Message-ID: 20130304112046.GA3943@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2013-03-04 11:51:36 +0100, Dimitri Fontaine wrote:
> - Assert() HeapTuple's catalog
>
> In the function extract_ctlversion() I would like to be able to
> Assert() that the given tuple is from the right catalog and didn't
> see how to do that

->t_tableOid. Haven't read the patch, so I am not sure whether thats a
good check to make.

Its not 100% useful, because several places neglect to set tableOid but
I have patch to remedy that (as part of the logical decoding work).

I can send that patch separated from other stuff if there's interest.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2013-03-04 12:01:17 Re: Matview patch added rewriteDefine.c.orig to the repository
Previous Message Dimitri Fontaine 2013-03-04 10:51:36 Re: in-catalog Extension Scripts and Control parameters (templates?)