Re: sql_drop Event Trigger

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: sql_drop Event Trigger
Date: 2013-02-28 21:43:40
Message-ID: 20130228214339.GQ9507@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dimitri Fontaine escribió:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> > I think it's fairly obvious that
> > (1) dealing with a DROP only after it's happened is pretty limiting;
> > (2) allowing user-defined code to run mid-command is dangerous.
> > What's at issue is the tradeoff we make between these inescapable
> > facts, and I'm not sure if we can get consensus on that.

Mmm.

> > On the whole, though, I'm thinking that the approach Robert suggests
> > is the way to go, because it doesn't foreclose our doing something
> > else later. Whereas if we ship 9.3 with a mid-DROP event, and we then
> > find out that it's even more dangerous than we currently realize,
> > we're going to be between a rock and a hard place.

Makes sense.

> The good news is that the patch to do that has already been sent on this
> list, and got reviewed in details by Álvaro who did offer incremental
> changes. Version 3 of that patch is to be found in:
>
> http://www.postgresql.org/message-id/m2fw19n1hr.fsf@2ndQuadrant.fr

As I recall there were a few more fixes I wanted to do on top of that
patch. I will see about that. Thanks for the pointer.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Christopher Browne 2013-02-28 21:59:07 Re: sql_drop Event Trigger
Previous Message Andrew Dunstan 2013-02-28 21:20:07 Re: Building on MinGW