| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | [RFC] Extend namespace of valid guc names |
| Date: | 2013-02-25 21:15:33 |
| Message-ID: | 20130225211533.GD3849@awork2.anarazel.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Currently guc-file.c allows the following as guc names:
ID {LETTER}{LETTER_OR_DIGIT}*
QUALIFIED_ID {ID}"."{ID}
That is either one token starting with a letter followed by numbers or
letters or exactly two of those separated by a dot.
Those restrictions are existing for neither SET/set_config() via SQL nor
for postgres -c styles of setting options.
I propose loosening those restrictions to
a) allow repeatedly qualified names like a.b.c
b) allow variables to start with a digit from the second level onwards.
Additionally, should we perhaps enforce the same rules for -c and
set_config()/SET?
Trivial patch that only extends the space of valid names for
postgresql.conf attached.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| allow-more-names-in-guc-c.patch | text/x-patch | 503 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2013-02-25 21:27:21 | Re: [RFC] Extend namespace of valid guc names |
| Previous Message | Robert Haas | 2013-02-25 20:26:04 | Re: auto_explain WAS: RFC: Timing Events |