From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Phil Sorber <phil(at)omniti(dot)com> |
Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] pg_isready (was: [WIP] pg_ping utility) |
Date: | 2013-01-28 18:12:35 |
Message-ID: | 20130128181234.GA4050@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Phil Sorber escribió:
> On Mon, Jan 28, 2013 at 11:20 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> > Maybe. But I'm not inclined to add new libpq interface at this stage.
> > Because we are in the last CommitFest and I'm not sure whether
> > we have enough time to implement that. Instead, how about using
> > both PQconninfoParse() and PQconndefaults() like uri-regress.c does?
> > Or just remove that output message? At least I don't think that the
> > information about host and port needs to be output. Which would make
> > the code very simpler.
>
> I think that output is important as do others up thread. I think it'd
> be simpler to just disable dbname's ability to double as conninfo. If
> we are looking for easy, that is.
>
> I don't mind duplicating the behavior from conninfo_array_parse() or
> uri-regress.c either. I can just put a comment that at some point in
> the future we should add a libpq interface for it.
I suggest duplicate the code for 9.3, and submit a patch to refactor
into a new libpq function for CF2013-next. If the patch is simple
enough, we can consider putting it into 9.3.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Phil Sorber | 2013-01-28 18:14:35 | Re: [PATCH] pg_isready (was: [WIP] pg_ping utility) |
Previous Message | Tom Lane | 2013-01-28 18:00:40 | Re: enhanced error fields |