From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Amit kapila <amit(dot)kapila(at)huawei(dot)com> |
Cc: | "robertmhaas(at)gmail(dot)com" <robertmhaas(at)gmail(dot)com>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Minor inheritance/check bug: Inconsistent behavior |
Date: | 2013-01-25 15:05:31 |
Message-ID: | 20130125150531.GW21914@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Sep 14, 2012 at 02:04:51PM +0000, Amit kapila wrote:
> On Thu, 6 Sep 2012 14:50:05 -0400 Robert Hass wrote:
>
> On Tue, Aug 28, 2012 at 6:40 AM, Amit Kapila <amit(dot)kapila(at)huawei(dot)
> com> wrote:
> >> AFAICT during Update also, it doesn't contain useful. The only chance it
> >> would have contain something useful is when it goes for EvalPlanQual and
> >> then again comes to check for constraints. However these attributes get
> >> filled in heap_update much later.
> >
> >> So now should the fix be that it returns an error for system column
> >> reference except for OID case?
>
> > +1.
>
>
>
> 1. I think in this scenario the error for system column except for tableOID
> should be thrown at Create/Alter time.
>
> 2. After setting OID in ExecInsert/ExecUpdate may be setting of same inside
> heap functions can be removed.
>
> But for now I have kept them as it is.
>
>
>
> Please find the Patch for bug-fix.
>
> If this is okay, I shall send you the test cases for same.
Did we ever make any progress on this?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2013-01-25 15:20:07 | Re: Skip checkpoint on promoting from streaming replication |
Previous Message | Robert Haas | 2013-01-25 15:04:19 | Re: Event Triggers: adding information |