Re: PITR potentially broken in 9.2

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: PITR potentially broken in 9.2
Date: 2012-12-05 01:10:07
Message-ID: 20121205011006.GA8970@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 2012-12-04 19:35:48 -0500, Tom Lane wrote:
> I wrote:
> > So apparently this is something we broke since Nov 18. Don't know what
> > yet --- any thoughts?
>
> Further experimentation shows that reverting commit
> ffc3172e4e3caee0327a7e4126b5e7a3c8a1c8cf makes it work. So there's
> something wrong/incomplete about that fix.

ISTM that the code should check ControlFile->backupEndRequired, not just
check for an invalid backupEndPoint. I haven't looked into the specific
issue though.

> This is a bit urgent since we now have to consider whether to withdraw
> 9.2.2 and issue a hasty 9.2.3. Do we have a regression here since
> 9.2.1, and if so how bad is it?

Not sure.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Jeff Janes 2012-12-05 02:05:15 Re: PITR potentially broken in 9.2
Previous Message elein 2012-12-05 00:44:39 BUG #7730: intarray representation of empty arrays

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Janes 2012-12-05 02:05:15 Re: PITR potentially broken in 9.2
Previous Message Noah Misch 2012-12-05 01:04:42 Re: Tablespaces in the data directory