| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Shigeru HANADA <shigeru(dot)hanada(at)gmail(dot)com> |
| Cc: | Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: FDW for PostgreSQL |
| Date: | 2012-10-23 15:35:23 |
| Message-ID: | 20121023153523.GG4971@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Shigeru HANADA escribió:
> Please examine attached v2 patch (note that is should be applied onto
> latest dblink_fdw_validator patch).
Tom committed parts of the dblink_fdw_validator patch, but not the
removal, so it seems this patch needs to be rebased on top of that
somehow. I am not able to say what's the best resolution for that
conflict, however. But it seems to me that maybe you will need to
choose a different name for the validator after all, to support binary
upgrades.
There are some other comments downthread that a followup patch probably
needs to address too, as well. I am marking this patch Returned with
Feedback. Please submit an updated version to CF3.
Thanks.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2012-10-23 16:02:13 | Re: too much pgbench init output |
| Previous Message | Alvaro Herrera | 2012-10-23 15:25:40 | Re: Re: proposal and patch : support INSERT INTO...RETURNING with partitioned table using rule |