Re: Bugs in CREATE/DROP INDEX CONCURRENTLY

From: "Kevin Grittner" <kgrittn(at)mail(dot)com>
To: "Simon Riggs" <simon(at)2ndQuadrant(dot)com>,"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Bugs in CREATE/DROP INDEX CONCURRENTLY
Date: 2012-10-17 20:52:38
Message-ID: 20121017205238.155620@gmx.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Simon Riggs wrote:
> On 6 October 2012 00:56, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

>> 2. DROP INDEX CONCURRENTLY doesn't bother to do
>> TransferPredicateLocksToHeapRelation until long after it's
>> invalidated the index. Surely that's no good? Is it even possible
>> to do that correctly, when we don't have a lock that will prevent
>> new predicate locks from being taken out meanwhile?
>
> No idea there. Input appreciated.

[Sorry for delayed response; fighting through a backlog.]

If the creation of a new tuple by insert or update would not perform
the related index tuple insertion, and the lock has not yet been
transfered to the heap relation, yes we have a problem.  Will take a
look at the code.

Creation of new predicate locks while in this state has no bearing on
the issue as long as locks are transferred to the heap relation after
the last scan using the index has completed.

-Kevin

Browse pgsql-hackers by date

  From Date Subject
Next Message Martijn van Oosterhout 2012-10-17 21:02:50 Re: Bugs in planner's equivalence-class processing
Previous Message Josh Berkus 2012-10-17 20:25:17 Re: [RFC] CREATE QUEUE (log-only table) for londiste/pgQ ccompatibility