| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
| Cc: | Qi Huang <huangqiyx(at)outlook(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH]Tablesample Submission |
| Date: | 2012-10-17 14:59:04 |
| Message-ID: | 20121017145904.GC5217@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hitoshi Harada escribió:
> Patch does not apply cleanly against latest master. outfuncs.c,
> allpath.c and cost.h have rejected parts. The make check failed in a
> lot of cases up to 26 out of 133. I didn't look into each issue but I
> suggest rebasing on the latest master and making sure the regression
> test passes.
We've been waiting for a rebase for long enough, so I've marked this
patch as Returned with Feedback (for which we thank Hitoshi Harada).
Since this is said to be useful functionality, please make sure you
update the patch and resubmit to the next commitfest. Thanks.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2012-10-17 15:01:57 | Re: Identity projection |
| Previous Message | Peter Geoghegan | 2012-10-17 14:29:08 | Re: [PATCH] Enforce that INSERT...RETURNING preserves the order of multi rows |