Re: Visual Studio 2012 RC

On Sun, Oct 14, 2012 at 11:13:46PM +0200, Brar Piening wrote:
> Noah Misch wrote:
>> Since SDK version 7.1 is named as the "latest supported version", I understand
>> from that text that installing SDK version 8.0a along with compilers from
>> another source (VS 2012 full, VS 2012 Express for Desktop) is considered
>> "unsupported" as a PostgreSQL build environment. Is that your intent?
> No, not really.
> What I want to say is that you'll need the SDK to build postgres.
> Using a Visual Studio version that ships with a supported SDK version
> (full versions of VS 2005 to 2010 as well as any version of VS 2012)
> will work.
> On the other hand standalone SDK versions that ship with compilers will
> also work.
> The major gotcha here is the fact that old sdk versions ship without
> compilers and old VS Express versions ship without SDK and you'll need
> both to build.

Thanks for clarifying.

On Sun, Oct 14, 2012 at 11:34:54PM +0200, Brar Piening wrote:
> Noah Misch wrote:
>> I decided to try a 32-bit build, but Solution::DeterminePlatform
>> detected it as x64. Its shibboleth is no longer valid; the cl.exe shipping
>> with VS 2012 Express for Desktop has a /favor option for both architectures:
>>
>> 32clhelp:/favor:<blend|ATOM> select processor to optimize for, one of:
>> 64clhelp:/favor:<blend|AMD64|INTEL64|ATOM> select processor to optimize for, one of:
>>
>> Overlaying the first attached change fixed detection for this particular
>> compiler, but I have not checked compatibility with older versions. Do you
>> have VS 2008 and/or VS 2010 handy?
> Older compilers work fine but localized ones will probably cause trouble
> (for -> f?r in german).
> I've decided to change the regex to "/^\/favor:<.+AMD64/" in my current
> version of the patch as this is not very likely to appear in a 32-bit
> environment and will not be subject ot localization problems.

Good call.

The only matter still requiring attention is a fix for IsoLocaleName().