Re: BUG #6150: commit_delay should have unit ms

On Tue, Aug 14, 2012 at 05:26:39PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Opps, turns out the units are microseconds (as pointed out to me by
> > Magnus), and we don't have a microsecond designation in that file, so I
> > reverted that and just added a C comment about why it has no units.
>
> Is it worth adding support for microseconds in there? Not sure.
>
> Technically it wouldn't be very hard, but I seem to recall this was
> discussed before and we were worried about whether people would be
> confused about what "ms" means. Don't know that "us" would be
> universally recognized, either.

Yes, I do remember the discussion. Because commit_delay is so rarely
used, and the only one that uses usec units by default, it didn't seem
to make sense to add documentation for an additional unit.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +