Re: Remove support in ri_triggers.c for zero-column foreign keys?

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Remove support in ri_triggers.c for zero-column foreign keys?
Date: 2012-06-20 21:24:14
Message-ID: 201206202324.14994.andres@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wednesday, June 20, 2012 11:15:44 PM Tom Lane wrote:
> There is a nontrivial amount of code in ri_triggers.c that is concerned
> with supporting foreign key constraints having zero columns. ...
>
> I think we should rip all that code out and instead put one test into
> ri_FetchConstraintInfo insisting that the number of keys be > 0.
+1. I really find that a strange concept and I have a hard time finding useful
use-cases.

Thanks for improving that code btw, I tried to read/patch it before and its
not exactly accessible...

Andres

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2012-06-20 21:28:11 Re: Remove support in ri_triggers.c for zero-column foreign keys?
Previous Message Tom Lane 2012-06-20 21:15:44 Remove support in ri_triggers.c for zero-column foreign keys?