Re: TOAST versus VACUUM, or "missing chunk number 0 for toast value" identified

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Hammond <andrew(dot)george(dot)hammond(at)gmail(dot)com>
Subject: Re: TOAST versus VACUUM, or "missing chunk number 0 for toast value" identified
Date: 2011-11-04 17:29:54
Message-ID: 201111041729.pA4HTsU21893@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Excerpts from Alvaro Herrera's message of vie oct 28 16:47:13 -0300 2011:
> >> BTW we had previous discussions about dropping pg_database's toast
> >> table. Maybe this is a good time to do it, even if there's no risk of
> >> this bug (or the hypothetical circularity detoasting problem) showing up
> >> there.
>
> No objection from me.
>
> > Oh, something unrelated I just remembered: we have
> > pg_database.datlastsysoid which seems unused. Perhaps we should remove
> > that column for cleanliness.
>
> I have a vague recollection that some client-side code uses this to
> figure out what's the dividing line between user and system OIDs.
> pg_dump used to need to know that number, and it can still be useful
> with casts and other things that are hard to tell whether they're built-in.
> While in principle people could use FirstNormalObjectId instead, that
> could come back to bite us if we ever have to increase that constant
> in future releases. I'm inclined to leave this one alone.

Maybe add a C comment?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-11-04 18:17:50 Re: heap_page_prune comments
Previous Message Bruce Momjian 2011-11-04 16:54:38 Re: unite recovery.conf and postgresql.conf