Re: TABLE tab completion

On Mon, Sep 26, 2011 at 10:37:50AM +0200, Magnus Hagander wrote:
> On Sun, Sep 25, 2011 at 15:06, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
> > On 24 September 2011 11:59, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> >> TABLE tab completion in psql only completes to tables, not views. but
> >> the TABLE command works fine for both tables and views (and also
> >> sequences).
> >>
> >> Seems we should just complete it to relations and not tables - or can
> >> anyone see a particular reason why we shouldn't?
> >>
> >
> > Doesn't that mean that "DROP TABLE <tab>" would offer up views as well
> > as tables, which would be incorrect?
>
> Meh - you are correct, of course. I guess that's why we have code review :-)
>
> So - not a oneliner, but how about something like this?
>
> (Happy to have someone point out a neater way of doing it, not
> entirely fluent in how we do the tab completion..)

That's pretty much it. Should it also (eventually) do SRFs?

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate