First bug introduced by pgrminclude

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: First bug introduced by pgrminclude
Date: 2011-09-07 17:00:27
Message-ID: 201109071700.p87H0RJ03567@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I have fixed a bug introduced by pgrminclude. It turns out that
CppAsString2() will expand any symbol, even one that is undefined, so
pgrminclude thought that catalog/catversion was not needed. This is
illustrated in the attached C file that outputs "1" and "y".

I have bumped the catalog version to force users to reload their
tablespaces (or use pg_upgrade) because the tablespace directory names
will not be expanded to the catalog version.

I have modified pgrminclude to skip files that use CppAsString2().

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

Attachment Content-Type Size
/rtmp/pgrminclude text/x-diff 984 bytes

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-09-07 17:05:09 Re: [v9.2] Fix Leaky View Problem
Previous Message Euler Taveira de Oliveira 2011-09-07 16:32:31 typo