Re: Problem with pg_upgrade's directory write check on Windows

Robert Haas wrote:
> On Sun, Jul 24, 2011 at 5:27 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Alvaro Herrera wrote:
> >> Excerpts from Bruce Momjian's message of dom jul 24 01:46:08 -0400 2011:
> >> > Robert Haas wrote:
> >>
> >> > > > Should I fix this in pg_upgrade 9.1 for Windows or just in 9.2? ?The
> >> > > > check works fine on non-Windows.
> >> > >
> >> > > Seems worth back-patching to me.
> >> >
> >> > Attached patch applied and backpatched to 9.1. ?I was able to test both
> >> > code paths on my BSD machine by modifying the ifdefs. ?I will have
> >> > EnterpriseDB do further testing.
> >>
> >> Err, why not 9.0?
> >
> > The check did not exist in 9.0 -- I mentioned that in the commit
> > message. ?I could add the check into 9.0, but we usually don't backpatch
> > such things.
>
> What do you mean by "such things"?

The check to see if the directory is writable was only in 9.1+ --- this
is a fix for that check. The check was not backpatched because we don't
ordinarly backpatch sanity checks for uncommon problems. We certainly
can't backpatch just the fix.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +