| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Problem with pg_upgrade's directory write check on Windows |
| Date: | 2011-07-24 21:27:34 |
| Message-ID: | 201107242127.p6OLRYs09645@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera wrote:
> Excerpts from Bruce Momjian's message of dom jul 24 01:46:08 -0400 2011:
> > Robert Haas wrote:
>
> > > > Should I fix this in pg_upgrade 9.1 for Windows or just in 9.2? ?The
> > > > check works fine on non-Windows.
> > >
> > > Seems worth back-patching to me.
> >
> > Attached patch applied and backpatched to 9.1. I was able to test both
> > code paths on my BSD machine by modifying the ifdefs. I will have
> > EnterpriseDB do further testing.
>
> Err, why not 9.0?
The check did not exist in 9.0 -- I mentioned that in the commit
message. I could add the check into 9.0, but we usually don't backpatch
such things.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joey Adams | 2011-07-24 22:48:12 | Re: Initial Review: JSON contrib modul was: Re: Another swing at JSON |
| Previous Message | Tom Lane | 2011-07-24 20:33:40 | Re: libpq SSL with non-blocking sockets |