Re: Re: patch review : Add ability to constrain backend temporary file space

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: josh(at)agliodbs(dot)com
Cc: cedric(dot)villemain(dot)debian(at)gmail(dot)com, mark(dot)kirkwood(at)catalyst(dot)net(dot)nz, robertmhaas(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: patch review : Add ability to constrain backend temporary file space
Date: 2011-07-14 06:48:24
Message-ID: 20110714.154824.579528996447115832.t-ishii@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Hackers,
>
> This patch needs a new reviewer, per Cedric. Please help!

Hi I am the new reviewer:-)

I have looked into the v6 patches. One thing I would like to suggest
is, enhancing the error message when temp_file_limit will be exceeded.

ERROR: aborting due to exceeding temp file limit

Is it possible to add the current temp file limit to the message? For
example,

ERROR: aborting due to exceeding temp file limit 10000kB

I know the current setting of temp_file_limit can be viewd in other
ways, but I think this will make admin's or application developer's
life a little bit easier.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hiroshi Saito 2011-07-14 07:05:00 Re: Full GUID support
Previous Message Jeff Davis 2011-07-14 06:21:19 Re: lazy vxid locks, v2