Re: Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.

Bruce Momjian wrote:
>
> Wow, this is the first I am hearing GNU cp -i can return zero exit if it
> doesn't do the copy. I tested this on Ubuntu 10.04 using cp 7.4 and
> got:
>
> $ touch x y
> $ cp -i x y; echo $?
> cp: overwrite `y'? n
> 0
>
> I see the same on my anchent BSD/OS machine too:
>
> $ touch x y
> $ cp -i x y; echo $?
> overwrite y? n
> 0
>
> Were we expecting an error if the file already existed? Assuming that,
> we should assume the file will always exist so basically archiving will
> never progress. Is this what we want? I just wasn't aware we were
> expecting an already-existing this to be an error --- I thought we just
> didn't want to overwrite it.

I tested on FreeBSD 7.4 and saw a 1 error return:

$ touch x y
$ cp -i x y; echo $?
overwrite y? (y/n [n]) n
not overwritten
1

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +