| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Thom Brown <thom(at)linux(dot)com> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: In pg_upgrade, check there are no prepared transactions. |
| Date: | 2011-06-14 19:00:53 |
| Message-ID: | 201106141900.p5EJ0rX24895@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Thom Brown wrote:
> On 14 June 2011 19:42, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > In pg_upgrade, check there are no prepared transactions.
>
> Out of curiosity, why would you check the new cluster for prepared transactions?
Yes, I was debating mentioning why I did that. First, the new cluster
should be empty, so there is a procedural issue that if it isn't, they
probably did something wrong. Second, I am worried that replying a
prepared transaction, now that transaction ids are now different
(remember we froze _everthing_) might not work, and I don't want to try
to find out that it works now and doesn't work later, to safety says to
just disallow it.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2011-06-14 20:30:47 | pgsql: Remove unused variable |
| Previous Message | Bruce Momjian | 2011-06-14 18:53:52 | pgsql: In pg_upgrade, check there are no prepared transactions. |