From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Noah Misch <noah(at)leadboat(dot)com> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_upgrade automatic testing |
Date: | 2011-06-02 23:05:15 |
Message-ID: | 201106022305.p52N5FS16030@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Noah Misch wrote:
> On Wed, May 25, 2011 at 10:07:45PM +0300, Peter Eisentraut wrote:
> > On ons, 2011-04-27 at 18:14 -0400, Noah Misch wrote:
> > > Enthusiastic +1 for this concept. There's at least one rough edge: it fails if
> > > you have another postmaster running on port 5432.
> >
> > This has now been addressed: pg_upgrade accepts PGPORT settings.
> > Attached is a slightly updated patch runs the test suite with a port of
> > 65432, which you can override by setting PGPORT yourself.
> >
> > Anyway, is this something that people want in the repository? It's not
> > as polished as the pg_regress business, but it is definitely helpful.
>
> I'd like it. We've had bugs sit for months that would have been found
> immediately by a buildfarm member running this test. Having it in the
> repository at least opens up that possibility.
Yep, looks fine to me.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2011-06-02 23:32:53 | Re: Minor issues with docs |
Previous Message | Mark Kirkwood | 2011-06-02 23:01:43 | Re: Re: patch review : Add ability to constrain backend temporary file space |