Re: pgindent weirdness

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgindent weirdness
Date: 2011-04-20 17:16:50
Message-ID: 201104201716.p3KHGoO06329@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas wrote:
> On Wed, Apr 20, 2011 at 11:15 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> > I did carefully warn you about the need to check the effects of the changes
> > when I committed the new list.
> >
> > It looks like quite a few of the deletions come into this category, for
> > example just looking at the diff here
> > <https://github.com/postgres/postgres/commit/fe1438da8aa8a45f2cee816eb54841f97d3b2f22#src/tools/pgindent/typedefs.list>
> > I see AggHashEntryData, AggStatePerAggData, AllocBlockData, and
> > AllocChunkData from among the first few that were deleted and all are in the
> > same category.
>
> This implies to me that we changed something about how we handle this
> since we did the 9.0 runs, but I don't know what it was. Should I?

I think Andrew also supplied the typedef list for the 9.0 run.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2011-04-20 17:17:50 Re: pgindent weirdness
Previous Message Robert Haas 2011-04-20 17:12:47 Re: pgindent weirdness