Re: pg_upgrade bug found!

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Noah Misch <noah(at)leadboat(dot)com>, RhodiumToad on IRC <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_upgrade bug found!
Date: 2011-04-08 17:35:33
Message-ID: 201104081735.p38HZX917884@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> New version; I made some other small adjustments:
>
> -- This script fixes data in pre-PG 9.0.4 and pre-8.4.8
> -- servers that was upgraded by pg_upgrade and pg_migrator.
> -- Run the script using psql for every database in the cluster
> -- except 'template0', e.g.:
> -- psql -U postgres -a -f pg_upgrade_fix.sql dbname
> -- This must be run from a writable directory.
> -- It will not lock any tables but will generate I/O.
> --
> CREATE TEMPORARY TABLE pg_upgrade_fix AS
> SELECT 'VACUUM FREEZE pg_toast.' || c.relname || ';'
> FROM pg_class c, pg_namespace n
> WHERE c.relnamespace = n.oid AND
> n.nspname = 'pg_toast' AND
> c.relkind = 't'
> ORDER by c.oid;
> \copy pg_upgrade_fix TO 'pg_upgrade_tmp.sql';
> \i pg_upgrade_tmp.sql

OK, now that I have committed the fixes to git, I think it is time to
consider how we are going to handle this fix for people who have already
used pg_upgrade, or are using it in currently released versions.

I am thinking an announce list email with this query would be enough,
and state that we are planning a minor release with this fix in the
next few weeks. I can provide details on the cause and behavior of the
bug.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-04-08 17:57:21 Re: Open issues for collations
Previous Message Noah Misch 2011-04-08 17:35:14 Re: pg_upgrade bug found!