Re: pg_upgrade bug found!

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, RhodiumToad on IRC <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_upgrade bug found!
Date: 2011-04-07 21:36:10
Message-ID: 201104072136.p37LaAu28792@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> Jeff Davis wrote:
> > On Thu, 2011-04-07 at 17:06 -0400, Bruce Momjian wrote:
> > > I want to avoid anything that requires a compile because they are hard
> > > for many sites to install so TransactionIdPrecedes() is out. We will
> > > need to do this in PL/pgSQL probably.
> >
> > PL/pgSQL can't see dead rows, so that would not be correct. It's
> > guaranteed to be the same value you see from the heap or newer; because
> > if it's not visible in the heap, it's not going to be visible in the
> > toast table.
>
> Well, frankly all we need to do is set those hint bits before the clog
> gets remove, so maybe just a SELECT * would do the trick! That and
> maybe set the relfrozenxid to match the heap.
>
> It is there now or more people would be reporting problems.

Clarification, "the clog" is there now or more people would be reporting
problems.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2011-04-07 21:38:13 Re: pg_upgrade bug found!
Previous Message Bruce Momjian 2011-04-07 21:32:13 Re: pg_upgrade bug found!