| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Christopher Browne <cbbrowne(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Macros for time magic values |
| Date: | 2011-03-11 18:09:48 |
| Message-ID: | 201103111809.p2BI9mY10089@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Christopher Browne wrote:
> On Fri, Mar 11, 2011 at 12:50 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > It has bothered me that many of our time routines use special magic
> > constants for time values, e.g. 24, 12, 60, etc.
> >
> > The attached patch changes these magic constants to macros to clarify
> > the code. ?I would like to apply this for 9.1 as a cleanup.
>
> The context diffs show off some references to 1901 and 2038...
>
> Here's a *possible* extension to this...
Interesting idea, but UTIME_MINYEAR/UTIME_MAXYEAR is only defined in
src/interfaces/ecpg/pgtypeslib/dt.h, and it seems odd to duplicate or
move them for just one use site.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-03-11 18:12:09 | Re: How should the waiting backends behave in sync rep? |
| Previous Message | Christopher Browne | 2011-03-11 17:58:01 | Re: Macros for time magic values |