From: | Rumko <rumcic(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Porting PostgreSQL to DragonFly BSD |
Date: | 2011-03-01 21:22:36 |
Message-ID: | 201103012222.38265.rumcic@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tuesday 1. of March 2011 16:07:47 Tom Lane wrote:
> Rumko <rumcic(at)gmail(dot)com> writes:
> > On Sunday 27. of February 2011 23:50:17 Peter Eisentraut wrote:
> >> It seems to me that it would be easier to just map dragonfly to the
> >> freebsd template.
> >
> > I didn't see a precedence for that kind of introduction of a new platform
> > (all others seem to have their own templates), so thought it would've had
> > less chance of being accepted.
>
> When I looked at that patch, I actually couldn't see anything different
> at all from freebsd. We aren't interested in maintaining 99% duplicate
> code --- it seems much easier from a maintenance standpoint to introduce
> an ifdef or two into the freebsd code, rather than deal with a large cut
> and paste job. Please try it that way and see what you come up with.
> (It's possible that it'll be so ugly that we agree your original patch
> is better, but we need to see the results of the experiment.)
>
> regards, tom lane
Well, wouldn't consider it ugly, but the patch (attached and available at
http://www.rumko.net/0001-DragonFly-BSD-support-linked.patch ) is a lot
shorter.
Uses freebsd's template and defines the linker in Makefile.shlib.
--
Regards,
Rumko
Attachment | Content-Type | Size |
---|---|---|
0001-DragonFly-BSD-support-linked.patch | text/plain | 1.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2011-03-01 21:23:17 | Re: Alpha4 release blockers (was Re: wrapping up this CommitFest) |
Previous Message | Dimitri Fontaine | 2011-03-01 21:20:59 | Re: Alpha4 release blockers (was Re: wrapping up this CommitFest) |