| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: REVIEW: Determining client_encoding from client locale |
| Date: | 2011-02-06 18:19:38 |
| Message-ID: | 20110206181938.GK4116@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Ibrar,
* Ibrar Ahmed (ibrar(dot)ahmad(at)gmail(dot)com) wrote:
> I have reviewed/tested this patch.
Great, thanks for that!
> In my point code should be like this
>
> *if (conn->client_encoding_initial && conn->client_encoding_initial[0])
> {
> if (packet)
> {
> strcpy(packet + packet_len, "client_encoding");
> packet_len += strlen("client_encoding") + 1;
> strcpy(packet + packet_len,
> conn->client_encoding_initial);
> packet_len += strlen(conn->client_encoding_initial) +
> 1;
> }
> }*
Makes sense to me, just reading through this email. Have you tested
this change..? Could you provide it as an additional patch or a new
patch including the change against head, assuming it still works well in
your testing?
> I will test this patch on Windows and will send results.
That would be great, it's not easy for me to test under Windows.
Thanks!
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-02-06 18:23:35 | A different approach to extension NO USER DATA feature |
| Previous Message | Stephen Frost | 2011-02-06 18:03:10 | Re: Add support for logging the current role |