Re: Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.
Date: 2010-11-29 19:09:29
Message-ID: 2011.1291057769@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Mon, Nov 29, 2010 at 16:26, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> That works for me. But should we make a practice of writing the
>> ENTIRE SHA-ID rather than an abbreviated form, so that we could more
>> easily replace 'em later if need be?

> I think that's a good idea.

Just as a data point, there is already one 7-hex-digit collision in our
repository:

Branch: master Release: REL6_1 [aaeef4dae] 1997-04-09 08:29:35 +0000
Branch: master Release: REL6_1 [aaeef4d17] 1996-11-10 03:06:38 +0000

I think it's quite foolish to depend on abbreviated hashes to be unique
forever.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message David Fetter 2010-11-29 21:14:54 Re: Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.
Previous Message Magnus Hagander 2010-11-29 18:58:39 Re: Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2010-11-29 19:14:12 Re: improving foreign key locks
Previous Message Magnus Hagander 2010-11-29 18:58:39 Re: Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.