Re: [sqlsmith] Missing CHECK_FOR_INTERRUPTS in tsquery_rewrite

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andreas Seltenreich <seltenreich(at)gmx(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [sqlsmith] Missing CHECK_FOR_INTERRUPTS in tsquery_rewrite
Date: 2016-10-30 17:40:29
Message-ID: 20109.1477849229@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Also, I think this is outright *wrong* for phrase search --- dropping some
> of the child nodes without any other adjustment isn't valid is it?

After further digging, it seems there's no bug because the tree is
originally binary and QTNTernary won't try to flatten OP_PHRASE nodes.
So we can't actually get to this logic for such nodes. But seems like
an Assert for that wouldn't be a bad thing.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2016-10-30 18:32:48 Re: Speed up Clog Access by increasing CLOG buffers
Previous Message Tom Lane 2016-10-30 17:19:26 Re: [sqlsmith] Missing CHECK_FOR_INTERRUPTS in tsquery_rewrite