Re: Problems with ALTER DOMAIN patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Rod Taylor <rbt(at)rbt(dot)ca>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Problems with ALTER DOMAIN patch
Date: 2002-12-11 23:35:54
Message-ID: 20102.1039649754@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> I have an idea. Rather than doing some complex locking for types, why
> don't we just restrict ALTER DOMAIN to cases where we are the only one
> attached to the database, as seen in dropdb().

Yech!

> would allow the regression test to work too because no one is attached
> to 'regression' at the time of the test.

No, we'd just get random reports of unreproducible failures.

FWIW, I frequently attach to the regression database with a manual psql
while the regression tests are running. It's a useful thing to do ---
I've more than once found bugs that way.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-12-12 00:00:08 Re: Problems with ALTER DOMAIN patch
Previous Message Kevin Brown 2002-12-11 23:30:47 Re: PQnotifies() in 7.3 broken?