Re: Tab completion for view triggers in psql

From: David Fetter <david(at)fetter(dot)org>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Tab completion for view triggers in psql
Date: 2010-11-22 01:35:37
Message-ID: 20101122013537.GK7424@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Nov 21, 2010 at 08:27:34PM -0500, Robert Haas wrote:
> On Sun, Nov 21, 2010 at 7:17 PM, David Fetter <david(at)fetter(dot)org> wrote:
> > On Sun, Nov 21, 2010 at 07:09:08PM -0500, Robert Haas wrote:
> >> On Sun, Nov 21, 2010 at 4:05 PM, David Fetter <david(at)fetter(dot)org> wrote:
> >> >> > Could someone please commit this? :)
> >> >>
> >> >> Eh... was there some reason you didn't add it to the
> >> >> CommitFest app?
> >> >
> >> > I forgot.
> >>
> >> A fair excuse.  :-)
> >>
> >> >> Because that's what I work from.
> >> >
> >> > It's pretty trivial, but I don't feel comfortable adding it
> >> > after the close. :/
> >>
> >> So add it to the next one, and we'll get it then if nobody picks
> >> it up sooner...
> >
> > Given its small and isolated nature, I was hoping we could get
> > this in sooner rather than later.  As I understand it, CFs are
> > there to review patches that take significant effort for even a
> > committer to understand, so this doesn't really fit that model.
>
> Well, then add it to this one if you think that's more appropriate.

Done. :)

> My point is simple: I review patches because they are in the CF
> queue. Your point seems to be: put mine ahead of the others, and
> review it immediately. Someone else may very well be willing to do
> that; I'm not.

Fair enough.

> > David (refraining from mentioning anything about the time taken
> > today to discuss this vs. the time it would have taken to push the
> > thing)
>
> Mention anything you want. My guess is it would take me an hour.
> You're certainly right that this discussion is a waste of time, but
> possibly not for the reasons you are supposing.

LOL!

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-11-22 01:39:02 Re: psql: Add \dL to show languages
Previous Message Robert Haas 2010-11-22 01:35:25 Re: Extensions, this time with a patch