Re: create tablespace fails silently, or succeeds improperly

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Dave Cramer <pg(at)fastcrypt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: create tablespace fails silently, or succeeds improperly
Date: 2010-10-18 18:20:02
Message-ID: 201010181820.o9IIK2Z01584@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera wrote:
> Hi Dave,
>
> Excerpts from Dave Cramer's message of lun oct 18 12:23:40 -0300 2010:
> > as seen below create tablespace does not throw an error or appear to
> > do anything other than register the tablespace.
> >
> > postgres(at)db01:~> less /opt/pg/data/jnj_indexes/PG_VERSION
> > 8.4
> > postgres(at)db01:~> /opt/pg91/bin/psql -p 5433
> > psql (9.0.1)
> > Type "help" for help.
> >
> > postgres=# select version();
> > version
> > -------------------------------------------------------------------------------------------------------------------
> > PostgreSQL 9.0.1 on x86_64-unknown-linux-gnu, compiled by GCC gcc
> > (GCC) 3.4.6 20060404 (Red Hat 3.4.6-11), 64-bit
> > (1 row)
> >
> > postgres=# create TABLESPACE jnj_indexes location '/opt/pg/data/jnj_indexes';
> > CREATE TABLESPACE
>
> IIRC the reason this works is that the tablespace code now creates a
> version-specific subdirectory inside the specified directory. This was
> done to help binary upgrades.

Right, the directory is catalog-version named, which was done to allow
for pg_upgrade to work for alpha/beta upgrades (pretty cool). The case
above happened because 8.4 still has data in that tablespace.
pg_upgrade does supply a script to delete old data files, but it was not
used in the case above.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2010-10-18 18:26:07 Re: Serializable snapshot isolation patch
Previous Message Robert Haas 2010-10-18 18:19:44 Re: create tablespace fails silently, or succeeds improperly