Re: create tablespace fails silently, or succeeds improperly

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Dave Cramer <pg(at)fastcrypt(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: create tablespace fails silently, or succeeds improperly
Date: 2010-10-18 18:17:31
Message-ID: 201010181817.o9IIHVb01180@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dave Cramer wrote:
> On Mon, Oct 18, 2010 at 11:37 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Dave Cramer <pg(at)fastcrypt(dot)com> writes:
> >> as seen below create tablespace does not throw an error or appear to
> >> do anything other than register the tablespace.
> >
> > I suspect this behavior is partially intentional, because tablespace
> > creation now involves an extra level of subdirectory. ?However, it's
> > not clear to me why CREATE TABLESPACE is still changing the permissions
> > on the parent directory. ?Bruce, exactly what is the rationale here?
>
> OK, it appears there are a few loose ends here then as the
> documentation http://www.postgresql.org/docs/9.0/interactive/sql-createtablespace.html
> says the directory needs to be empty.

Docs updated to say "should", not "must", be empty. Backpatched to
9.0.X. If we need more change, I can do those too.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

Attachment Content-Type Size
/rtmp/diff text/x-diff 655 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-10-18 18:17:55 Re: ISN patch that applies cleanly with git apply
Previous Message Tom Lane 2010-10-18 18:08:37 Re: WIP: extensible enums