[REVIEW] Re: I: About "Our CLUSTER implementation is pessimal" patch

From: Abhijit Menon-Sen <ams(at)toroid(dot)org>
To: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: [REVIEW] Re: I: About "Our CLUSTER implementation is pessimal" patch
Date: 2010-09-16 07:49:06
Message-ID: 20100916074906.GA5038@toroid.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

(Sorry for the broken threading. I didn't have a convenient copy of the
original message to reply to.)

I looked at the patch and it seems quite reasonable, but two hunks of
the changes to src/backend/commands/cluster.c don't apply cleanly. I'm
not sure what version the patch was generated against, but the code in
copy_heap_data() seems to have changed quite a bit. I don't think it
would be too much trouble to adapt the changes, though.

-- ams

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Vaibhav Kaushal 2010-09-16 08:04:26 Introducing Myself
Previous Message Andrew Dunstan 2010-09-16 07:29:48 Re: bad variable subst after "AS"