pgsql: Replace max_standby_delay with two parameters,

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Replace max_standby_delay with two parameters,
Date: 2010-07-03 20:43:58
Message-ID: 20100703204358.7AFC47541D4@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Replace max_standby_delay with two parameters, max_standby_archive_delay and
max_standby_streaming_delay, and revise the implementation to avoid assuming
that timestamps found in WAL records can meaningfully be compared to clock
time on the standby server. Instead, the delay limits are compared to the
elapsed time since we last obtained a new WAL segment from archive or since
we were last "caught up" to WAL data arriving via streaming replication.
This avoids problems with clock skew between primary and standby, as well
as other corner cases that the original coding would misbehave in, such
as the primary server having significant idle time between transactions.
Per my complaint some time ago and considerable ensuing discussion.

Do some desultory editing on the hot standby documentation, too.

Modified Files:
--------------
pgsql/doc/src/sgml:
config.sgml (r1.288 -> r1.289)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/config.sgml?r1=1.288&r2=1.289)
high-availability.sgml (r1.76 -> r1.77)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/high-availability.sgml?r1=1.76&r2=1.77)
pgsql/src/backend/access/transam:
xlog.c (r1.427 -> r1.428)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/xlog.c?r1=1.427&r2=1.428)
pgsql/src/backend/replication:
walreceiver.c (r1.14 -> r1.15)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/replication/walreceiver.c?r1=1.14&r2=1.15)
walreceiverfuncs.c (r1.5 -> r1.6)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/replication/walreceiverfuncs.c?r1=1.5&r2=1.6)
pgsql/src/backend/storage/ipc:
standby.c (r1.25 -> r1.26)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/ipc/standby.c?r1=1.25&r2=1.26)
pgsql/src/backend/storage/lmgr:
proc.c (r1.219 -> r1.220)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/lmgr/proc.c?r1=1.219&r2=1.220)
pgsql/src/backend/utils/misc:
guc.c (r1.557 -> r1.558)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.557&r2=1.558)
postgresql.conf.sample (r1.288 -> r1.289)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/postgresql.conf.sample?r1=1.288&r2=1.289)
pgsql/src/include/access:
xlog.h (r1.113 -> r1.114)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/xlog.h?r1=1.113&r2=1.114)
pgsql/src/include/replication:
walreceiver.h (r1.9 -> r1.10)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/replication/walreceiver.h?r1=1.9&r2=1.10)
pgsql/src/include/storage:
standby.h (r1.10 -> r1.11)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/storage/standby.h?r1=1.10&r2=1.11)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-07-03 21:23:58 pgsql: Make vacuum_defer_cleanup_age be PGC_SIGHUP level, since it's not
Previous Message Bruce Momjian 2010-07-03 17:21:49 pgsql: Document more clearly on XML namespaces inside xpath function