| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: superfluous copydir() prototype in pg_upgrade.h |
| Date: | 2010-07-01 14:37:57 |
| Message-ID: | 201007011437.o61Ebv105009@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > While looking at Guillaume Lelarge's patch to add
> > CHECK_FOR_INTERRUPTS() within copydir(), I noticed that we seem to
> > have a $SUBJECT.
>
> > Trivial patch attached.
>
> The rmtree() declaration below it shouldn't be there either ...
When pg_upgrade was not in /contrib, I was concerned about including
port.h, but at this point, I think it is fine. Both removed.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ None of us is going to be here forever. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-07-01 15:04:30 | Re: bitmap indexes - performance |
| Previous Message | Tom Lane | 2010-07-01 14:35:45 | Re: superfluous copydir() prototype in pg_upgrade.h |